Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimal version of php to 7.4 #27

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Bump minimal version of php to 7.4 #27

merged 13 commits into from
Jan 9, 2024

Conversation

sveneld
Copy link
Contributor

@sveneld sveneld commented Jan 8, 2024

Bump minimal version of php to 7.4
Add strict types
Append types to properties and functions

jparise
jparise reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think package.xml also needs a small update.

@sveneld
Copy link
Contributor Author

sveneld commented Jan 8, 2024

update minimal version in package.xml

@sveneld
Copy link
Contributor Author

sveneld commented Jan 8, 2024

I think after merge of this pull request new version can be released here and on the PEAR

@jparise jparise merged commit 8b36e7f into pear:master Jan 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveneld @jparise